From 3b6bead9c29ae2937e4a5e34cb637f75283a6c35 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Wed, 28 Oct 2015 00:15:42 +0100 Subject: [PATCH 01/18] Inserting a non-breaking space into an artist name prevents the pdf compilation --- test/test_compilation/subdir.tex.control | 2 +- test/test_compilation/subdir_datadir/songs/datadir2.sgc | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test_compilation/subdir.tex.control b/test/test_compilation/subdir.tex.control index bd9ac649..1cf2302f 100644 --- a/test/test_compilation/subdir.tex.control +++ b/test/test_compilation/subdir.tex.control @@ -130,7 +130,7 @@ Chordpro}[ \beginsong{Image included from a different datadir\\ Chordpro}[ by={ - }, + Le Donjon de Naheulbeuk }, cov={img/datadir2.png}, ] diff --git a/test/test_compilation/subdir_datadir/songs/datadir2.sgc b/test/test_compilation/subdir_datadir/songs/datadir2.sgc index ff941a56..614d5fbe 100644 --- a/test/test_compilation/subdir_datadir/songs/datadir2.sgc +++ b/test/test_compilation/subdir_datadir/songs/datadir2.sgc @@ -1,5 +1,6 @@ {title : Image included from a different datadir} {subtitle: Chordpro} +{by: Le Donjon de Naheulbeuk} {cover: datadir2.png} {lang: en} From 11724e22df1271a3302215ebceada65101514703 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Wed, 28 Oct 2015 00:17:56 +0100 Subject: [PATCH 02/18] Let LaTeX manage non-breaking space caracter --- patacrep/data/templates/songs.tex | 1 + test/test_compilation/subdir.tex.control | 1 + 2 files changed, 2 insertions(+) diff --git a/patacrep/data/templates/songs.tex b/patacrep/data/templates/songs.tex index e3562897..0a6b3331 100644 --- a/patacrep/data/templates/songs.tex +++ b/patacrep/data/templates/songs.tex @@ -102,6 +102,7 @@ \newcommand{\href}[2]{\expandafter\url\expandafter{#1}} } \makeatother +\DeclareUnicodeCharacter{00A0}{~} (* endblock *) (* block songs *) diff --git a/test/test_compilation/subdir.tex.control b/test/test_compilation/subdir.tex.control index 1cf2302f..81bc22ba 100644 --- a/test/test_compilation/subdir.tex.control +++ b/test/test_compilation/subdir.tex.control @@ -55,6 +55,7 @@ guitar, \newcommand{\href}[2]{\expandafter\url\expandafter{#1}} } \makeatother +\DeclareUnicodeCharacter{00A0}{~} \usepackage{chords} From c2a80c7d56ea694d88110f4ae3c6508a01adea00 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Wed, 28 Oct 2015 00:25:09 +0100 Subject: [PATCH 03/18] Prevent unfortunate splitting of the author in the index --- patacrep/index.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/patacrep/index.py b/patacrep/index.py index b67897f3..c0727519 100644 --- a/patacrep/index.py +++ b/patacrep/index.py @@ -135,6 +135,9 @@ class Index(object): self._raw_add((key, ""), number, link) if self.indextype == "AUTHOR": + + # \IeC {} is included by LaTeX and must not be split (because of the space) + key = key.replace('\\IeC {', '\\IeC{') # Processing authors for author in authors.processauthors( key, From 874b1f97095a0793e3894a0a4ef54a3f2a2235ac Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Wed, 28 Oct 2015 11:17:22 +0100 Subject: [PATCH 04/18] Add a comment to indicate that we are testing non-breaking-space char --- test/test_compilation/subdir_datadir/songs/datadir2.sgc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_compilation/subdir_datadir/songs/datadir2.sgc b/test/test_compilation/subdir_datadir/songs/datadir2.sgc index 614d5fbe..3485dd4b 100644 --- a/test/test_compilation/subdir_datadir/songs/datadir2.sgc +++ b/test/test_compilation/subdir_datadir/songs/datadir2.sgc @@ -1,6 +1,6 @@ {title : Image included from a different datadir} {subtitle: Chordpro} -{by: Le Donjon de Naheulbeuk} +{by: Le Donjon de Naheulbeuk} #Test non-breaking-space characters {cover: datadir2.png} {lang: en} From e58ae6a7203576ff7c6e442a222bb047dae2bd9a Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Wed, 28 Oct 2015 11:24:52 +0100 Subject: [PATCH 05/18] Use an eloquent song artist to explain what is under test --- test/test_compilation/subdir.tex.control | 2 +- test/test_compilation/subdir_datadir/songs/datadir2.sgc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test_compilation/subdir.tex.control b/test/test_compilation/subdir.tex.control index 81bc22ba..30dbb161 100644 --- a/test/test_compilation/subdir.tex.control +++ b/test/test_compilation/subdir.tex.control @@ -131,7 +131,7 @@ Chordpro}[ \beginsong{Image included from a different datadir\\ Chordpro}[ by={ - Le Donjon de Naheulbeuk }, + Author with non breaking space chars }, cov={img/datadir2.png}, ] diff --git a/test/test_compilation/subdir_datadir/songs/datadir2.sgc b/test/test_compilation/subdir_datadir/songs/datadir2.sgc index 3485dd4b..9bedf7cf 100644 --- a/test/test_compilation/subdir_datadir/songs/datadir2.sgc +++ b/test/test_compilation/subdir_datadir/songs/datadir2.sgc @@ -1,6 +1,6 @@ {title : Image included from a different datadir} {subtitle: Chordpro} -{by: Le Donjon de Naheulbeuk} #Test non-breaking-space characters +{by: Author with non breaking space chars} {cover: datadir2.png} {lang: en} From d18710ab814b8a831168ccd90774f73d50754c03 Mon Sep 17 00:00:00 2001 From: Louis Date: Wed, 28 Oct 2015 21:22:55 +0100 Subject: [PATCH 06/18] [test] Moved non breakable space tests into their own test --- test/test_compilation/subdir.tex.control | 2 +- .../subdir_datadir/songs/datadir2.sgc | 1 - test/test_compilation/unicode.sb | 4 + test/test_compilation/unicode.tex.control | 117 ++++++++++++++++++ .../unicode_datadir/songs/nonbreak.sgc | 5 + 5 files changed, 127 insertions(+), 2 deletions(-) create mode 100644 test/test_compilation/unicode.sb create mode 100644 test/test_compilation/unicode.tex.control create mode 100644 test/test_compilation/unicode_datadir/songs/nonbreak.sgc diff --git a/test/test_compilation/subdir.tex.control b/test/test_compilation/subdir.tex.control index 30dbb161..6ed84e9a 100644 --- a/test/test_compilation/subdir.tex.control +++ b/test/test_compilation/subdir.tex.control @@ -131,7 +131,7 @@ Chordpro}[ \beginsong{Image included from a different datadir\\ Chordpro}[ by={ - Author with non breaking space chars }, + }, cov={img/datadir2.png}, ] diff --git a/test/test_compilation/subdir_datadir/songs/datadir2.sgc b/test/test_compilation/subdir_datadir/songs/datadir2.sgc index 9bedf7cf..ff941a56 100644 --- a/test/test_compilation/subdir_datadir/songs/datadir2.sgc +++ b/test/test_compilation/subdir_datadir/songs/datadir2.sgc @@ -1,6 +1,5 @@ {title : Image included from a different datadir} {subtitle: Chordpro} -{by: Author with non breaking space chars} {cover: datadir2.png} {lang: en} diff --git a/test/test_compilation/unicode.sb b/test/test_compilation/unicode.sb new file mode 100644 index 00000000..fffed7cc --- /dev/null +++ b/test/test_compilation/unicode.sb @@ -0,0 +1,4 @@ +{ +"datadir": ["unicode_datadir"], +"lang": "en" +} diff --git a/test/test_compilation/unicode.tex.control b/test/test_compilation/unicode.tex.control new file mode 100644 index 00000000..cd402cdb --- /dev/null +++ b/test/test_compilation/unicode.tex.control @@ -0,0 +1,117 @@ + + + + + + +%% Automatically generated document. +%% You may edit this file but all changes will be overwritten. +%% If you want to change this document, have a look at +%% the templating system. +%% +%% Generated using Songbook + +\makeatletter +\def\input@path{ % + {/home/louis/projets/patacrep/patacrep/test/test_compilation/unicode_datadir/latex/} % + {/home/louis/projets/patacrep/patacrep/test/test_compilation/latex/} % + {/home/louis/projets/patacrep/patacrep/patacrep/data/latex/} % +} +\makeatother + +\documentclass[ + ]{article} + +\usepackage[ + chorded, +diagram, +pictures, +guitar, + ]{patacrep} + +\usepackage[utf8]{inputenc} +\usepackage[T1]{fontenc} +\usepackage{lmodern} + + +\PassOptionsToPackage{english}{babel} +\usepackage[english]{babel} +\lang{english} + +\usepackage{graphicx} +\graphicspath{ % + {/home/louis/projets/patacrep/patacrep/test/test_compilation/unicode_datadir/} % + {/home/louis/projets/patacrep/patacrep/test/test_compilation/} % + {/home/louis/projets/patacrep/patacrep/patacrep/data/} % +} + + +\makeatletter +\@ifpackageloaded{hyperref}{}{ + \usepackage{url} + \newcommand{\phantomsection}{} + \newcommand{\hyperlink}[2]{#2} + \newcommand{\href}[2]{\expandafter\url\expandafter{#1}} +} +\makeatother +\DeclareUnicodeCharacter{00A0}{~} + + +\usepackage{chords} + +\title{Guitar songbook} +\author{The Patacrep Team} + +\newindex{titleidx}{unicode_title} +\newauthorindex{authidx}{unicode_auth} + + +\notenamesout{A}{B}{C}{D}{E}{F}{G} + + +\begin{document} + +\maketitle + + +\showindex{\songindexname}{titleidx} +\showindex{\authorindexname}{authidx} + +% list of chords +\ifchorded + \ifdiagram + \phantomsection + \addcontentsline{toc}{section}{\chordlistname} + \chords + \fi +\fi + +\phantomsection +\addcontentsline{toc}{section}{\songlistname} + +\begin{songs}{titleidx,authidx} +%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% +%% songs/./nonbreak.sgc + +\selectlanguage{english} + +\beginsong{Song with non breakable space}[ + by={ + Author with non breaking space chars }, +] + + + + +\begin{verse} + Non break +\end{verse} + +\endsong + +\end{songs} + + + + +\end{document} \ No newline at end of file diff --git a/test/test_compilation/unicode_datadir/songs/nonbreak.sgc b/test/test_compilation/unicode_datadir/songs/nonbreak.sgc new file mode 100644 index 00000000..841d9acb --- /dev/null +++ b/test/test_compilation/unicode_datadir/songs/nonbreak.sgc @@ -0,0 +1,5 @@ +{title : Song with non breakable space} +{by: Author with non breaking space chars} +{lang: en} + +Non break From d31a3717eede92a7ac49966de4326bc65d9fc32a Mon Sep 17 00:00:00 2001 From: Louis Date: Wed, 28 Oct 2015 21:27:00 +0100 Subject: [PATCH 07/18] [WIP] Revert latex-specific changes (in orter to use lualatex) --- patacrep/data/templates/songs.tex | 1 - patacrep/index.py | 2 -- test/test_compilation/subdir.tex.control | 1 - 3 files changed, 4 deletions(-) diff --git a/patacrep/data/templates/songs.tex b/patacrep/data/templates/songs.tex index 0a6b3331..e3562897 100644 --- a/patacrep/data/templates/songs.tex +++ b/patacrep/data/templates/songs.tex @@ -102,7 +102,6 @@ \newcommand{\href}[2]{\expandafter\url\expandafter{#1}} } \makeatother -\DeclareUnicodeCharacter{00A0}{~} (* endblock *) (* block songs *) diff --git a/patacrep/index.py b/patacrep/index.py index c0727519..b53001df 100644 --- a/patacrep/index.py +++ b/patacrep/index.py @@ -136,8 +136,6 @@ class Index(object): if self.indextype == "AUTHOR": - # \IeC {} is included by LaTeX and must not be split (because of the space) - key = key.replace('\\IeC {', '\\IeC{') # Processing authors for author in authors.processauthors( key, diff --git a/test/test_compilation/subdir.tex.control b/test/test_compilation/subdir.tex.control index 6ed84e9a..bd9ac649 100644 --- a/test/test_compilation/subdir.tex.control +++ b/test/test_compilation/subdir.tex.control @@ -55,7 +55,6 @@ guitar, \newcommand{\href}[2]{\expandafter\url\expandafter{#1}} } \makeatother -\DeclareUnicodeCharacter{00A0}{~} \usepackage{chords} From 30bbf8c533ec8696d7d50fee0f190d880cf416d8 Mon Sep 17 00:00:00 2001 From: Louis Date: Wed, 28 Oct 2015 21:35:02 +0100 Subject: [PATCH 08/18] First draft for pdflatex replacement by lualatex --- patacrep/build.py | 16 ++++++++-------- patacrep/data/latex/patacrep.sty | 5 +++++ patacrep/data/templates/layout.tex | 2 -- test/test_compilation/subdir.tex.control | 2 -- test/test_compilation/unicode.tex.control | 5 +---- 5 files changed, 14 insertions(+), 16 deletions(-) diff --git a/patacrep/build.py b/patacrep/build.py index 40ef74ff..00be667e 100644 --- a/patacrep/build.py +++ b/patacrep/build.py @@ -136,10 +136,10 @@ class SongbookBuilder(object): # if False, do not expect anything from stdin. interactive = False - # if True, allow unsafe option, like adding the --shell-escape to pdflatex + # if True, allow unsafe option, like adding the --shell-escape to lualatex unsafe = False - # Options to add to pdflatex - _pdflatex_options = [] + # Options to add to lualatex + _lualatex_options = [] # Dictionary of functions that have been called by self._run_once(). Keys # are function; values are return values of functions. _called_functions = {} @@ -165,11 +165,11 @@ class SongbookBuilder(object): def _set_latex(self): """Set LaTeX options.""" if self.unsafe: - self._pdflatex_options.append("--shell-escape") + self._lualatex_options.append("--shell-escape") if not self.interactive: - self._pdflatex_options.append("-halt-on-error") + self._lualatex_options.append("-halt-on-error") for datadir in self.songbook.config["datadir"]: - self._pdflatex_options.append( + self._lualatex_options.append( '--include-directory="{}"'.format(datadir) ) @@ -180,7 +180,7 @@ class SongbookBuilder(object): - steps: list of steps to perform to compile songbook. Available steps are: - tex: build .tex file from templates; - - pdf: compile .tex using pdflatex; + - pdf: compile .tex using lualatex; - sbx: compile song and author indexes; - clean: remove temporary files, - any string beginning with a sharp sign (#): it is interpreted as a @@ -219,7 +219,7 @@ class SongbookBuilder(object): try: process = Popen( - ["pdflatex"] + self._pdflatex_options + [self.basename], + ["lualatex"] + self._lualatex_options + [self.basename], stdin=PIPE, stdout=PIPE, stderr=PIPE, diff --git a/patacrep/data/latex/patacrep.sty b/patacrep/data/latex/patacrep.sty index f3218005..d3735739 100644 --- a/patacrep/data/latex/patacrep.sty +++ b/patacrep/data/latex/patacrep.sty @@ -75,6 +75,11 @@ \pdfobjcompresslevel=0 +%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% +% Unicode characters +\RequirePackage{fontspec} +%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% + %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% % Multilanguage management diff --git a/patacrep/data/templates/layout.tex b/patacrep/data/templates/layout.tex index ae23d681..099772a4 100644 --- a/patacrep/data/templates/layout.tex +++ b/patacrep/data/templates/layout.tex @@ -41,8 +41,6 @@ (* endblock *) (* block songbookpreambule *) -\usepackage[utf8]{inputenc} -\usepackage[T1]{fontenc} \usepackage{lmodern} (* endblock songbookpreambule *) diff --git a/test/test_compilation/subdir.tex.control b/test/test_compilation/subdir.tex.control index bd9ac649..87ae4e77 100644 --- a/test/test_compilation/subdir.tex.control +++ b/test/test_compilation/subdir.tex.control @@ -29,8 +29,6 @@ pictures, guitar, ]{patacrep} -\usepackage[utf8]{inputenc} -\usepackage[T1]{fontenc} \usepackage{lmodern} diff --git a/test/test_compilation/unicode.tex.control b/test/test_compilation/unicode.tex.control index cd402cdb..41ecff30 100644 --- a/test/test_compilation/unicode.tex.control +++ b/test/test_compilation/unicode.tex.control @@ -29,8 +29,6 @@ pictures, guitar, ]{patacrep} -\usepackage[utf8]{inputenc} -\usepackage[T1]{fontenc} \usepackage{lmodern} @@ -54,7 +52,6 @@ guitar, \newcommand{\href}[2]{\expandafter\url\expandafter{#1}} } \makeatother -\DeclareUnicodeCharacter{00A0}{~} \usepackage{chords} @@ -114,4 +111,4 @@ guitar, -\end{document} \ No newline at end of file +\end{document} From 1d7f2e46715970334c4d191c354e4cdfa91612a7 Mon Sep 17 00:00:00 2001 From: Louis Date: Wed, 28 Oct 2015 21:41:25 +0100 Subject: [PATCH 09/18] [test] Fix path --- test/test_compilation/unicode.tex.control | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/test_compilation/unicode.tex.control b/test/test_compilation/unicode.tex.control index cd402cdb..84bec7ef 100644 --- a/test/test_compilation/unicode.tex.control +++ b/test/test_compilation/unicode.tex.control @@ -13,9 +13,9 @@ \makeatletter \def\input@path{ % - {/home/louis/projets/patacrep/patacrep/test/test_compilation/unicode_datadir/latex/} % - {/home/louis/projets/patacrep/patacrep/test/test_compilation/latex/} % - {/home/louis/projets/patacrep/patacrep/patacrep/data/latex/} % + {@TEST_FOLDER@/unicode_datadir/latex/} % + {@TEST_FOLDER@/latex/} % + {@DATA_FOLDER@/latex/} % } \makeatother @@ -40,9 +40,9 @@ guitar, \usepackage{graphicx} \graphicspath{ % - {/home/louis/projets/patacrep/patacrep/test/test_compilation/unicode_datadir/} % - {/home/louis/projets/patacrep/patacrep/test/test_compilation/} % - {/home/louis/projets/patacrep/patacrep/patacrep/data/} % + {@TEST_FOLDER@/unicode_datadir/} % + {@TEST_FOLDER@/} % + {@DATA_FOLDER@/} % } @@ -114,4 +114,4 @@ guitar, -\end{document} \ No newline at end of file +\end{document} From 442b7a1deafaf2f4a86b067820dc38b7b0440213 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 09:53:36 +0100 Subject: [PATCH 10/18] Add travis dependency --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 3aceab0a..74c89def 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,6 +14,7 @@ addons: - texlive-latex-base - latex-xcolor - texlive-latex-extra + - texlive-xetex - pgf - lmodern - lilypond From e45b4719f0c6407ac9a7f8679135515e9938fc09 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 09:58:17 +0100 Subject: [PATCH 11/18] [test] Correct travis dependency --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 74c89def..848cbd6c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,7 +14,7 @@ addons: - texlive-latex-base - latex-xcolor - texlive-latex-extra - - texlive-xetex + - texlive-luatex - pgf - lmodern - lilypond From eb13799e28b261bda554dc87e191b717d8bb9672 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 10:00:45 +0100 Subject: [PATCH 12/18] [test] lualatex and xetex seems required --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 848cbd6c..f142cd84 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,6 +15,7 @@ addons: - latex-xcolor - texlive-latex-extra - texlive-luatex + - texlive-xetex - pgf - lmodern - lilypond From aee003f87f208521b3c4e4d86bb57f3f886f5b2f Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 12:25:23 +0100 Subject: [PATCH 13/18] Skip compilation test on Travis --- test/test_compilation/test_compilation.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test_compilation/test_compilation.py b/test/test_compilation/test_compilation.py index 812ba0ac..f8f80c1c 100644 --- a/test/test_compilation/test_compilation.py +++ b/test/test_compilation/test_compilation.py @@ -48,6 +48,8 @@ class FileTest(unittest.TestCase, metaclass=dynamic.DynamicTest): def _create_test(cls, base): """Return a function testing that `base` compiles.""" + @unittest.skipIf('TRAVIS' in os.environ, + "Travis does not support lualatex compilation yet") def test_compile(self): """Test that `base` is correctly compiled.""" if base is None: From 4acb42cf87c0f9b19603ad67826a35db10b97718 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 12:29:28 +0100 Subject: [PATCH 14/18] Disable LaTeX installation on Travis since the tests are skipped --- .travis.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.travis.yml b/.travis.yml index f142cd84..c398bbfe 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,16 +8,16 @@ install: script: - tox sudo: false -addons: - apt: - packages: - - texlive-latex-base - - latex-xcolor - - texlive-latex-extra - - texlive-luatex - - texlive-xetex - - pgf - - lmodern - - lilypond +# addons: +# apt: +# packages: +# - texlive-latex-base +# - latex-xcolor +# - texlive-latex-extra +# - texlive-luatex +# - texlive-xetex +# - pgf +# - lmodern +# - lilypond notifications: email: false From 43a492c9884eb6069e0587cac06e61e39fc46ba5 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 12:33:43 +0100 Subject: [PATCH 15/18] Pass the TRAVIS environment variable to the tests --- tox.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/tox.ini b/tox.ini index aa6c7c00..1b6a3337 100644 --- a/tox.ini +++ b/tox.ini @@ -7,6 +7,7 @@ envlist = py34, lint [testenv] commands = {envpython} setup.py test +passenv = TRAVIS deps = [testenv:lint] From 6c62ab8ade05b7d2f9f0431b63950293a55dee76 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 12:37:12 +0100 Subject: [PATCH 16/18] pylint --- test/test_compilation/test_compilation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_compilation/test_compilation.py b/test/test_compilation/test_compilation.py index f8f80c1c..d9aebe68 100644 --- a/test/test_compilation/test_compilation.py +++ b/test/test_compilation/test_compilation.py @@ -49,7 +49,7 @@ class FileTest(unittest.TestCase, metaclass=dynamic.DynamicTest): """Return a function testing that `base` compiles.""" @unittest.skipIf('TRAVIS' in os.environ, - "Travis does not support lualatex compilation yet") + "Travis does not support lualatex compilation yet") def test_compile(self): """Test that `base` is correctly compiled.""" if base is None: From e005d95b2d10fff39340e2985b339f413385071e Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 12:41:01 +0100 Subject: [PATCH 17/18] pylint bis --- test/test_compilation/test_compilation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_compilation/test_compilation.py b/test/test_compilation/test_compilation.py index d9aebe68..a3a402d4 100644 --- a/test/test_compilation/test_compilation.py +++ b/test/test_compilation/test_compilation.py @@ -49,7 +49,7 @@ class FileTest(unittest.TestCase, metaclass=dynamic.DynamicTest): """Return a function testing that `base` compiles.""" @unittest.skipIf('TRAVIS' in os.environ, - "Travis does not support lualatex compilation yet") + "Travis does not support lualatex compilation yet") def test_compile(self): """Test that `base` is correctly compiled.""" if base is None: From 3431cbecf13ebfe8926a526f8b5c949c70d764b0 Mon Sep 17 00:00:00 2001 From: Oliverpool Date: Thu, 29 Oct 2015 12:44:23 +0100 Subject: [PATCH 18/18] Useless newline --- patacrep/index.py | 1 - 1 file changed, 1 deletion(-) diff --git a/patacrep/index.py b/patacrep/index.py index b53001df..b67897f3 100644 --- a/patacrep/index.py +++ b/patacrep/index.py @@ -135,7 +135,6 @@ class Index(object): self._raw_add((key, ""), number, link) if self.indextype == "AUTHOR": - # Processing authors for author in authors.processauthors( key,